OSDN Git Service

drm/virtio: fix an error code in virtio_gpu_init()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 3 Feb 2021 09:54:24 +0000 (12:54 +0300)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 3 Feb 2021 13:52:44 +0000 (14:52 +0100)
If devm_request_mem_region() fails this code currently returns success
but it should return -EBUSY.

Fixes: 6076a9711dc5 ("drm/virtio: implement blob resources: probe for host visible region")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: http://patchwork.freedesktop.org/patch/msgid/YBpy0GS7GfmafMfe@mwanda
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/virtio/virtgpu_kms.c

index b4ec479..b375394 100644 (file)
@@ -163,6 +163,7 @@ int virtio_gpu_init(struct drm_device *dev)
                                             vgdev->host_visible_region.len,
                                             dev_name(&vgdev->vdev->dev))) {
                        DRM_ERROR("Could not reserve host visible region\n");
+                       ret = -EBUSY;
                        goto err_vqs;
                }