OSDN Git Service

netdevsim: Fix unsigned being compared to less than zero
authorColin Ian King <colin.king@canonical.com>
Thu, 3 Jun 2021 21:56:57 +0000 (22:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Jun 2021 22:33:17 +0000 (15:33 -0700)
The comparison of len < 0 is always false because len is a size_t. Fix
this by making len a ssize_t instead.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: d395381909a3 ("netdevsim: Add max_vfs to bus_dev")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netdevsim/bus.c

index b56003d..ccec299 100644 (file)
@@ -111,7 +111,7 @@ ssize_t nsim_bus_dev_max_vfs_read(struct file *file,
 {
        struct nsim_bus_dev *nsim_bus_dev = file->private_data;
        char buf[11];
-       size_t len;
+       ssize_t len;
 
        len = snprintf(buf, sizeof(buf), "%u\n", nsim_bus_dev->max_vfs);
        if (len < 0)