OSDN Git Service

media: staging: improves comparisons readability in atomisp-ov5693
authorRiccardo Schirone <sirmy15@gmail.com>
Tue, 28 Nov 2017 20:40:03 +0000 (15:40 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 29 Dec 2017 11:23:24 +0000 (06:23 -0500)
Fix "Comparisons should place the constant on the right side of the
test" checkpatch issue.

Signed-off-by: Riccardo Schirone <sirmy15@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c

index b3be89e..5d84cde 100644 (file)
@@ -764,7 +764,7 @@ static int __ov5693_otp_read(struct v4l2_subdev *sd, u8 *buf)
                //pr_debug("BANK[%2d] %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x\n", i, *b, *(b+1), *(b+2), *(b+3), *(b+4), *(b+5), *(b+6), *(b+7), *(b+8), *(b+9), *(b+10), *(b+11), *(b+12), *(b+13), *(b+14), *(b+15));
 
                //Intel OTP map, try to read 320byts first.
-               if (21 == i) {
+               if (i == 21) {
                        if ((*b) == 0) {
                                dev->otp_size = 320;
                                break;
@@ -772,7 +772,7 @@ static int __ov5693_otp_read(struct v4l2_subdev *sd, u8 *buf)
                                b = buf;
                                continue;
                        }
-               } else if (24 == i) {           //if the first 320bytes data doesn't not exist, try to read the next 32bytes data.
+               } else if (i == 24) {           //if the first 320bytes data doesn't not exist, try to read the next 32bytes data.
                        if ((*b) == 0) {
                                dev->otp_size = 32;
                                break;
@@ -780,7 +780,7 @@ static int __ov5693_otp_read(struct v4l2_subdev *sd, u8 *buf)
                                b = buf;
                                continue;
                        }
-               } else if (27 == i) {           //if the prvious 32bytes data doesn't exist, try to read the next 32bytes data again.
+               } else if (i == 27) {           //if the prvious 32bytes data doesn't exist, try to read the next 32bytes data again.
                        if ((*b) == 0) {
                                dev->otp_size = 32;
                                break;
@@ -1348,7 +1348,7 @@ static int __power_up(struct v4l2_subdev *sd)
        struct i2c_client *client = v4l2_get_subdevdata(sd);
        int ret;
 
-       if (NULL == dev->platform_data) {
+       if (!dev->platform_data) {
                dev_err(&client->dev,
                        "no camera_sensor_platform_data");
                return -ENODEV;
@@ -1396,7 +1396,7 @@ static int power_down(struct v4l2_subdev *sd)
        int ret = 0;
 
        dev->focus = OV5693_INVALID_CONFIG;
-       if (NULL == dev->platform_data) {
+       if (!dev->platform_data) {
                dev_err(&client->dev,
                        "no camera_sensor_platform_data");
                return -ENODEV;