OSDN Git Service
(root)
/
android-x86
/
frameworks-base.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
28ff9ce
)
Fix bug in edge case for statsd anomaly tracking.
author
David Chen
<dwchen@google.com>
Tue, 20 Feb 2018 21:22:53 +0000
(13:22 -0800)
committer
David Chen
<dwchen@google.com>
Tue, 20 Feb 2018 21:22:53 +0000
(13:22 -0800)
Getting a past bucket value will always crash for anomalies
configured to track only the most recent one bucket.
Test: N/A
Change-Id: I2cd1c82fe8ba4cecb4fac21038bb5f04a60c360e
cmds/statsd/src/anomaly/AnomalyTracker.cpp
patch
|
blob
|
history
diff --git
a/cmds/statsd/src/anomaly/AnomalyTracker.cpp
b/cmds/statsd/src/anomaly/AnomalyTracker.cpp
index
443d33d
..
6553a14
100644
(file)
--- a/
cmds/statsd/src/anomaly/AnomalyTracker.cpp
+++ b/
cmds/statsd/src/anomaly/AnomalyTracker.cpp
@@
-149,6
+149,10
@@
void AnomalyTracker::addBucketToSum(const shared_ptr<DimToValMap>& bucket) {
int64_t AnomalyTracker::getPastBucketValue(const MetricDimensionKey& key,
const int64_t& bucketNum) const {
+ if (mNumOfPastBuckets == 0) {
+ return 0;
+ }
+
const auto& bucket = mPastBuckets[index(bucketNum)];
if (bucket == nullptr) {
return 0;