OSDN Git Service

drm/i915: Initialize err in remap_io_sg()
authorJosé Roberto de Souza <jose.souza@intel.com>
Mon, 17 May 2021 20:21:17 +0000 (13:21 -0700)
committerJosé Roberto de Souza <jose.souza@intel.com>
Tue, 18 May 2021 18:00:07 +0000 (11:00 -0700)
If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first
iteration, err is uninitialized causing a wrong call to zap_vma_ptes().

But that is impossible to happen as a scatterlist must have at least
one valid segment.
Anyways to avoid more reports from static checkers initializing ret
here.

Fixes: b12d691ea5e0 ("i915: fix remap_io_sg to verify the pgprot")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Ausmus <james.ausmus@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210517202117.179303-1-jose.souza@intel.com
drivers/gpu/drm/i915/i915_mm.c

index 4c8cd08..25576fa 100644 (file)
@@ -47,7 +47,7 @@ int remap_io_sg(struct vm_area_struct *vma,
                struct scatterlist *sgl, resource_size_t iobase)
 {
        unsigned long pfn, len, remapped = 0;
-       int err;
+       int err = 0;
 
        /* We rely on prevalidation of the io-mapping to skip track_pfn(). */
        GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);