OSDN Git Service

drm/i915/cnl: Remove spurious central_freq.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 14 Nov 2017 19:47:53 +0000 (11:47 -0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 16 Nov 2017 17:43:37 +0000 (09:43 -0800)
"Display software must leave this field at the default value.
It no longer needs to be configured as part of PLL programming."

We respect this already and we are setting up the default
one line below: "DPLL_CFGCR1_CENTRAL_FREQ".

Also we don't touch anywhere else this central_freq for cnl.
So let's remove from the final write.

No functional change. Only a clean-up patch.

Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Mika Kahola <mika.kahola@intel.com>
Cc: James Ausmus <james.ausmus@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171114194759.24541-2-rodrigo.vivi@intel.com
drivers/gpu/drm/i915/intel_dpll_mgr.c

index be74d47..61c684a 100644 (file)
@@ -2265,7 +2265,6 @@ static bool cnl_ddi_hdmi_pll_dividers(struct intel_crtc *crtc,
                DPLL_CFGCR1_QDIV_MODE(wrpll_params.qdiv_mode) |
                DPLL_CFGCR1_KDIV(wrpll_params.kdiv) |
                DPLL_CFGCR1_PDIV(wrpll_params.pdiv) |
-               wrpll_params.central_freq |
                DPLL_CFGCR1_CENTRAL_FREQ;
 
        memset(&crtc_state->dpll_hw_state, 0,