OSDN Git Service

scsi: st: remove unneeded variable 'result' in st_release()
authorJason Yan <yanaijie@huawei.com>
Sat, 18 Apr 2020 07:06:05 +0000 (15:06 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 22 Apr 2020 04:05:29 +0000 (00:05 -0400)
Also remove a strange '^L' after this function.

Fix the following coccicheck warning:

drivers/scsi/st.c:1460:5-11: Unneeded variable: "result". Return "0" on
line 1473

Link: https://lore.kernel.org/r/20200418070605.11450-1-yanaijie@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/st.c

index c5f9b34..4bf4ab3 100644 (file)
@@ -1457,7 +1457,6 @@ static int st_flush(struct file *filp, fl_owner_t id)
    accessing this tape. */
 static int st_release(struct inode *inode, struct file *filp)
 {
-       int result = 0;
        struct scsi_tape *STp = filp->private_data;
 
        if (STp->door_locked == ST_LOCKED_AUTO)
@@ -1470,9 +1469,9 @@ static int st_release(struct inode *inode, struct file *filp)
        scsi_autopm_put_device(STp->device);
        scsi_tape_put(STp);
 
-       return result;
+       return 0;
 }
-\f
+
 /* The checks common to both reading and writing */
 static ssize_t rw_checks(struct scsi_tape *STp, struct file *filp, size_t count)
 {