sim: bfin: allow pushing of SP

The hardware respects this insn, and some code (like the on-chip bootrom)
uses it, so allow it.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

diff --git a/sim/bfin/ChangeLog b/sim/bfin/ChangeLog
index a69d6e2..b1d4c9b 100644 (file)
--- a/sim/bfin/ChangeLog
+++ b/sim/bfin/ChangeLog
@@ -1,5 +1,10 @@
 2011-05-14  Mike Frysinger  <vapier@gentoo.org>
 
+       * bfin-sim.c (decode_PushPopReg_0): Delete (grp == 1 && reg == 6)
+       check for SP reg.
+
+2011-05-14  Mike Frysinger  <vapier@gentoo.org>
+
        * dv-bfin_uart.c (bfin_uart_write_byte): Add a mcr arg.  Declare a
        local uart.  When LOOP_ENA is set in mcr, write to the saved byte
        and count fields of the uart.

diff --git a/sim/bfin/bfin-sim.c b/sim/bfin/bfin-sim.c
index 13e8850..1cdfd27 100644 (file)
--- a/sim/bfin/bfin-sim.c
+++ b/sim/bfin/bfin-sim.c
@@ -2035,8 +2035,7 @@ decode_PushPopReg_0 (SIM_CPU *cpu, bu16 iw0)
   else
     {
       TRACE_INSN (cpu, "[--SP] = %s;", reg_name);
-      /* Can't push SP.  */
-      if (INSN_LEN == 8 || (grp == 1 && reg == 6))
+      if (INSN_LEN == 8)
        illegal_instruction_combination (cpu);
 
       sp -= 4;