OSDN Git Service

soc: fsl: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:23 +0000 (08:47 -0600)
committerArnd Bergmann <arnd@arndb.de>
Fri, 14 Apr 2023 12:58:50 +0000 (14:58 +0200)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/soc/fsl/qbman/dpaa_sys.c

index 9dd8bb5..3375145 100644 (file)
@@ -39,8 +39,7 @@ int qbman_init_private_mem(struct device *dev, int idx, dma_addr_t *addr,
 {
        struct device_node *mem_node;
        struct reserved_mem *rmem;
-       struct property *prop;
-       int len, err;
+       int err;
        __be32 *res_array;
 
        mem_node = of_parse_phandle(dev->of_node, "memory-region", idx);
@@ -63,8 +62,9 @@ int qbman_init_private_mem(struct device *dev, int idx, dma_addr_t *addr,
         * This is needed because QBMan HW does not allow the base address/
         * size to be modified once set.
         */
-       prop = of_find_property(mem_node, "reg", &len);
-       if (!prop) {
+       if (!of_property_present(mem_node, "reg")) {
+               struct property *prop;
+
                prop = devm_kzalloc(dev, sizeof(*prop), GFP_KERNEL);
                if (!prop)
                        return -ENOMEM;