OSDN Git Service

nvme-fc: remove NVME_FC_MAX_SEGMENTS
authorJames Smart <jsmart2021@gmail.com>
Mon, 23 Oct 2017 22:11:36 +0000 (15:11 -0700)
committerChristoph Hellwig <hch@lst.de>
Fri, 27 Oct 2017 06:25:35 +0000 (09:25 +0300)
The define is an arbitrary limit to the io size on the initiator,
capping the io to 1MB-4KB.

Remove the define from the transport. I/O size will solely be limited
by the LLDD sg limits.

Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/fc.c
include/linux/nvme-fc-driver.h

index d12775d..b600c07 100644 (file)
@@ -2435,7 +2435,6 @@ static int
 nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
 {
        struct nvmf_ctrl_options *opts = ctrl->ctrl.opts;
-       u32 segs;
        int ret;
        bool changed;
 
@@ -2486,9 +2485,8 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl)
        if (ret)
                goto out_disconnect_admin_queue;
 
-       segs = min_t(u32, NVME_FC_MAX_SEGMENTS,
-                       ctrl->lport->ops->max_sgl_segments);
-       ctrl->ctrl.max_hw_sectors = (segs - 1) << (PAGE_SHIFT - 9);
+       ctrl->ctrl.max_hw_sectors =
+               (ctrl->lport->ops->max_sgl_segments - 1) << (PAGE_SHIFT - 9);
 
        ret = nvme_init_identify(&ctrl->ctrl);
        if (ret)
index 4ea03b9..2be4db3 100644 (file)
@@ -102,8 +102,6 @@ enum nvmefc_fcp_datadir {
 };
 
 
-#define NVME_FC_MAX_SEGMENTS           256
-
 /**
  * struct nvmefc_fcp_req - Request structure passed from NVME-FC transport
  *                         to LLDD in order to perform a NVME FCP IO operation.