OSDN Git Service

memory: atmel-ebi: fix return value check in at91_ebi_dev_disable()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 16 Sep 2016 13:03:47 +0000 (13:03 +0000)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Thu, 20 Oct 2016 09:59:22 +0000 (11:59 +0200)
Fix the retrn value check which testing the wrong variable
in at91_ebi_dev_disable().

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/memory/atmel-ebi.c

index b5ed3bd..047d6fc 100644 (file)
@@ -657,7 +657,7 @@ static int at91_ebi_dev_disable(struct at91_ebi *ebi, struct device_node *np)
                return -ENOMEM;
 
        newprop->value = devm_kstrdup(dev, "disabled", GFP_KERNEL);
-       if (!newprop->name)
+       if (!newprop->value)
                return -ENOMEM;
 
        newprop->length = sizeof("disabled");