OSDN Git Service

radv: Don't check for pipeline being set in draw.
authorBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Tue, 19 Jun 2018 08:03:20 +0000 (10:03 +0200)
committerBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Tue, 19 Jun 2018 20:35:13 +0000 (22:35 +0200)
Draws without pipeline are definitely not allowed.

Fixes Coverity issue 1434216.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
src/amd/vulkan/radv_cmd_buffer.c

index 6134749..7454b39 100644 (file)
@@ -3366,7 +3366,6 @@ radv_draw(struct radv_cmd_buffer *cmd_buffer,
                cmd_buffer->device->physical_device->rad_info.chip_class >= CIK;
        bool pipeline_is_dirty =
                (cmd_buffer->state.dirty & RADV_CMD_DIRTY_PIPELINE) &&
-               cmd_buffer->state.pipeline &&
                cmd_buffer->state.pipeline != cmd_buffer->state.emitted_pipeline;
 
        MAYBE_UNUSED unsigned cdw_max =