OSDN Git Service

net: dsa: hellcreek: Don't print error message on defer
authorKurt Kanzenbach <kurt@linutronix.de>
Sat, 21 Nov 2020 11:44:55 +0000 (12:44 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 24 Nov 2020 00:57:21 +0000 (16:57 -0800)
When DSA is not loaded when the driver is probed an error message is
printed. But, that's not really an error, just a defer. Use dev_err_probe()
instead.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/hirschmann/hellcreek.c

index d42f40c..6420b76 100644 (file)
@@ -1266,7 +1266,7 @@ static int hellcreek_probe(struct platform_device *pdev)
 
        ret = dsa_register_switch(hellcreek->ds);
        if (ret) {
-               dev_err(dev, "Unable to register switch\n");
+               dev_err_probe(dev, ret, "Unable to register switch\n");
                return ret;
        }