OSDN Git Service

platform/x86: serial-multi-instantiate: Use while (i--) pattern to clean up
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Sat, 9 Jul 2022 21:16:51 +0000 (00:16 +0300)
committerHans de Goede <hdegoede@redhat.com>
Sun, 10 Jul 2022 15:59:51 +0000 (17:59 +0200)
Use more natural while (i--) patter to clean up allocated resources.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220709211653.18938-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/serial-multi-instantiate.c

index 970ede0..0a23356 100644 (file)
@@ -70,11 +70,11 @@ static int smi_get_irq(struct platform_device *pdev, struct acpi_device *adev,
 
 static void smi_devs_unregister(struct smi *smi)
 {
-       while (smi->i2c_num > 0)
-               i2c_unregister_device(smi->i2c_devs[--smi->i2c_num]);
+       while (smi->i2c_num--)
+               i2c_unregister_device(smi->i2c_devs[smi->i2c_num]);
 
-       while (smi->spi_num > 0)
-               spi_unregister_device(smi->spi_devs[--smi->spi_num]);
+       while (smi->spi_num--)
+               spi_unregister_device(smi->spi_devs[smi->spi_num]);
 }
 
 /**