OSDN Git Service

drm/sun4i: tcon: Delete an error message in sun4i_tcon_init_irq()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 5 Apr 2020 11:45:53 +0000 (13:45 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 6 Apr 2020 08:19:25 +0000 (10:19 +0200)
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/5a6cf5a7-3f27-5425-4d6a-550a17bc51e3@web.de
drivers/gpu/drm/sun4i/sun4i_tcon.c

index 624437b..359b56e 100644 (file)
@@ -812,10 +812,8 @@ static int sun4i_tcon_init_irq(struct device *dev,
        int irq, ret;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "Couldn't retrieve the TCON interrupt\n");
+       if (irq < 0)
                return irq;
-       }
 
        ret = devm_request_irq(dev, irq, sun4i_tcon_handler, 0,
                               dev_name(dev), tcon);