OSDN Git Service

tracing: Remove unused variable 'dups'
authorChen Zhongjin <chenzhongjin@huawei.com>
Fri, 30 Sep 2022 10:32:36 +0000 (18:32 +0800)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Mon, 3 Oct 2022 16:20:31 +0000 (12:20 -0400)
Reported by Clang [-Wunused-but-set-variable]

'commit c193707dde77 ("tracing: Remove code which merges duplicates")'
This commit removed the code which merges duplicates in detect_dups(),
but forgot to delete the variable 'dups' which used to merge
duplicates in the loop.

Now only 'total_dups' is needed, remove 'dups' for clean code.

Link: https://lkml.kernel.org/r/20220930103236.253985-1-chenzhongjin@huawei.com
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/tracing_map.c

index 9901708..c774e56 100644 (file)
@@ -961,7 +961,7 @@ create_sort_entry(void *key, struct tracing_map_elt *elt)
 static void detect_dups(struct tracing_map_sort_entry **sort_entries,
                      int n_entries, unsigned int key_size)
 {
-       unsigned int dups = 0, total_dups = 0;
+       unsigned int total_dups = 0;
        int i;
        void *key;
 
@@ -974,11 +974,10 @@ static void detect_dups(struct tracing_map_sort_entry **sort_entries,
        key = sort_entries[0]->key;
        for (i = 1; i < n_entries; i++) {
                if (!memcmp(sort_entries[i]->key, key, key_size)) {
-                       dups++; total_dups++;
+                       total_dups++;
                        continue;
                }
                key = sort_entries[i]->key;
-               dups = 0;
        }
 
        WARN_ONCE(total_dups > 0,