OSDN Git Service

staging: comedi: pcmuio: kzalloc'ed data does not need cleared
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Tue, 18 Jun 2013 20:23:02 +0000 (13:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Jun 2013 22:51:02 +0000 (15:51 -0700)
The 'subpriv' pointer is kzalloc'ed during the attach.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/pcmuio.c

index b348e2c..2e08e66 100644 (file)
@@ -713,7 +713,6 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
                s->insn_config = pcmuio_dio_insn_config;
                s->n_chan = min(chans_left, MAX_CHANS_PER_SUBDEV);
                subpriv->intr.asic = -1;
-               subpriv->intr.active = 0;
                s->len_chanlist = 1;
 
                /* save the ioport address for each 'port' of 8 channels in the
@@ -733,8 +732,6 @@ static int pcmuio_attach(struct comedi_device *dev, struct comedi_devconfig *it)
                            && subpriv->intr.asic < 0) {
                                /* setup the interrupt subdevice */
                                subpriv->intr.asic = asic;
-                               subpriv->intr.active = 0;
-                               subpriv->intr.stop_count = 0;
                                dev->read_subdev = s;
                                s->subdev_flags |= SDF_CMD_READ;
                                s->cancel = pcmuio_cancel;