drm/i915/dg2: Move misplaced 'ctx' & 'gt' wa's to engine wa list

Registers that belong to the shared render/compute reset domain need to
be placed on an engine workaround list to ensure that they are properly
re-applied whenever any RCS or CCS engine is reset, even if the
registers do not belong to a specific engine's MMIO range.  We have a
number of workarounds today that are incorrectly implemented on the 'gt'
workaround list and need to be moved accordingly.  We also have one
workaround (Wa_22012532006) that is incorrectly implemented on the
context workaround list, even though the register it is adjusting is not
part of the RCS engine's context image; it must also be moved.

We'll have some workaround refactoring coming in the near future that
deals with registers in the reset domain in a more clear way.  But in
the meantime, we should just move these workarounds to
rcs_engine_wa_init() to place them on the RCS engine's workaround list.
All production DG2 platforms will have an RCS engine (it's never fused
off) so these registers will be properly restored after a domain reset
triggered via an RCS engine _or_ a CCS engine.

Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.s@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220215235531.2236399-1-matthew.d.roper@intel.com

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 77ac294..1912a86 100644 (file)
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -681,12 +681,6 @@ static void dg2_ctx_workarounds_init(struct intel_engine_cs *engine,
        /* Wa_16013271637:dg2 */
        wa_masked_en(wal, SLICE_COMMON_ECO_CHICKEN1,
                     MSC_MSAA_REODER_BUF_BYPASS_DISABLE);
-
-       /* Wa_22012532006:dg2 */
-       if (IS_DG2_GRAPHICS_STEP(engine->i915, G10, STEP_A0, STEP_C0) ||
-           IS_DG2_GRAPHICS_STEP(engine->i915, G11, STEP_A0, STEP_B0))
-               wa_masked_en(wal, GEN9_HALF_SLICE_CHICKEN7,
-                            DG2_DISABLE_ROUND_ENABLE_ALLOW_FOR_SSLA);
 }
 
 static void fakewa_disable_nestedbb_mode(struct intel_engine_cs *engine,
@@ -1438,10 +1432,6 @@ dg2_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
        }
 
        if (IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_B0)) {
-               /* Wa_14010680813:dg2_g10 */
-               wa_write_or(wal, GEN12_GAMSTLB_CTRL, CONTROL_BLOCK_CLKGATE_DIS |
-                           EGRESS_BLOCK_CLKGATE_DIS | TAG_BLOCK_CLKGATE_DIS);
-
                /* Wa_14010948348:dg2_g10 */
                wa_write_or(wal, UNSLCGCTL9430, MSQDUNIT_CLKGATE_DIS);
 
@@ -1488,16 +1478,6 @@ dg2_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
                wa_write_or(wal, SSMCGCTL9530, RTFUNIT_CLKGATE_DIS);
        }
 
-       if (IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_B0) ||
-           IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0)) {
-               /* Wa_14012362059:dg2 */
-               wa_write_or(wal, GEN12_MERT_MOD_CTRL, FORCE_MISS_FTLB);
-       }
-
-       /* Wa_1509235366:dg2 */
-       wa_write_or(wal, GEN12_GAMCNTRL_CTRL, INVALIDATION_BROADCAST_MODE_DIS |
-                   GLOBAL_INVALIDATION_MODE);
-
        /* Wa_14014830051:dg2 */
        wa_write_clr(wal, SARB_CHICKEN1, COMP_CKN_IN);
 
@@ -1506,14 +1486,7 @@ dg2_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
         * recommended tuning settings documented in the bspec's
         * performance guide section.
         */
-       wa_write_or(wal, XEHP_L3SCQREG7, BLEND_FILL_CACHING_OPT_DIS);
        wa_write_or(wal, GEN12_SQCM, EN_32B_ACCESS);
-
-       /* Wa_18018781329:dg2 */
-       wa_write_or(wal, RENDER_MOD_CTRL, FORCE_MISS_FTLB);
-       wa_write_or(wal, COMP_MOD_CTRL, FORCE_MISS_FTLB);
-       wa_write_or(wal, VDBX_MOD_CTRL, FORCE_MISS_FTLB);
-       wa_write_or(wal, VEBX_MOD_CTRL, FORCE_MISS_FTLB);
 }
 
 static void
@@ -2047,6 +2020,23 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
        if (IS_DG2(i915)) {
                /* Wa_14015227452:dg2 */
                wa_masked_en(wal, GEN9_ROW_CHICKEN4, XEHP_DIS_BBL_SYSPIPE);
+
+               /* Wa_1509235366:dg2 */
+               wa_write_or(wal, GEN12_GAMCNTRL_CTRL, INVALIDATION_BROADCAST_MODE_DIS |
+                           GLOBAL_INVALIDATION_MODE);
+
+               /*
+                * The following are not actually "workarounds" but rather
+                * recommended tuning settings documented in the bspec's
+                * performance guide section.
+                */
+               wa_write_or(wal, XEHP_L3SCQREG7, BLEND_FILL_CACHING_OPT_DIS);
+
+               /* Wa_18018781329:dg2 */
+               wa_write_or(wal, RENDER_MOD_CTRL, FORCE_MISS_FTLB);
+               wa_write_or(wal, COMP_MOD_CTRL, FORCE_MISS_FTLB);
+               wa_write_or(wal, VDBX_MOD_CTRL, FORCE_MISS_FTLB);
+               wa_write_or(wal, VEBX_MOD_CTRL, FORCE_MISS_FTLB);
        }
 
        if (IS_DG2_GRAPHICS_STEP(i915, G11, STEP_A0, STEP_B0)) {
@@ -2147,6 +2137,24 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
            IS_DG2_GRAPHICS_STEP(i915, G11, STEP_A0, STEP_B0))
                wa_write_or(wal, RT_CTRL, DIS_NULL_QUERY);
 
+       /* Wa_22012532006:dg2 */
+       if (IS_DG2_GRAPHICS_STEP(engine->i915, G10, STEP_A0, STEP_C0) ||
+           IS_DG2_GRAPHICS_STEP(engine->i915, G11, STEP_A0, STEP_B0))
+               wa_masked_en(wal, GEN9_HALF_SLICE_CHICKEN7,
+                            DG2_DISABLE_ROUND_ENABLE_ALLOW_FOR_SSLA);
+
+       if (IS_DG2_GRAPHICS_STEP(engine->i915, G10, STEP_A0, STEP_B0)) {
+               /* Wa_14010680813:dg2_g10 */
+               wa_write_or(wal, GEN12_GAMSTLB_CTRL, CONTROL_BLOCK_CLKGATE_DIS |
+                           EGRESS_BLOCK_CLKGATE_DIS | TAG_BLOCK_CLKGATE_DIS);
+       }
+
+       if (IS_DG2_GRAPHICS_STEP(engine->i915, G10, STEP_A0, STEP_B0) ||
+           IS_DG2_GRAPHICS_STEP(engine->i915, G11, STEP_A0, STEP_B0)) {
+               /* Wa_14012362059:dg2 */
+               wa_write_or(wal, GEN12_MERT_MOD_CTRL, FORCE_MISS_FTLB);
+       }
+
        if (IS_DG1_GRAPHICS_STEP(i915, STEP_A0, STEP_B0) ||
            IS_TGL_UY_GRAPHICS_STEP(i915, STEP_A0, STEP_B0)) {
                /*