OSDN Git Service

net: hdlc_ppp: remove unnecessary out of memory message
authorPeng Li <lipeng321@huawei.com>
Thu, 17 Jun 2021 14:03:18 +0000 (22:03 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Jun 2021 19:08:46 +0000 (12:08 -0700)
This patch removes unnecessary out of memory message,
to fix the following checkpatch.pl warning:
"WARNING: Possible unnecessary 'out of memory' message"

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/hdlc_ppp.c

index fb5102c..aec9cc4 100644 (file)
@@ -219,10 +219,9 @@ static void ppp_tx_cp(struct net_device *dev, u16 pid, u8 code,
 
        skb = dev_alloc_skb(sizeof(struct hdlc_header) +
                            sizeof(struct cp_header) + magic_len + len);
-       if (!skb) {
-               netdev_warn(dev, "out of memory in ppp_tx_cp()\n");
+       if (!skb)
                return;
-       }
+
        skb_reserve(skb, sizeof(struct hdlc_header));
 
        cp = skb_put(skb, sizeof(struct cp_header));