OSDN Git Service

block: Update flags in bdrv_set_read_only()
authorKevin Wolf <kwolf@redhat.com>
Tue, 9 Oct 2018 14:57:12 +0000 (16:57 +0200)
committerKevin Wolf <kwolf@redhat.com>
Mon, 5 Nov 2018 14:09:55 +0000 (15:09 +0100)
To fully change the read-only state of a node, we must not only change
bs->read_only, but also update bs->open_flags.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
block.c

diff --git a/block.c b/block.c
index 9d2adf7..3132c78 100644 (file)
--- a/block.c
+++ b/block.c
@@ -281,6 +281,13 @@ int bdrv_set_read_only(BlockDriverState *bs, bool read_only, Error **errp)
     }
 
     bs->read_only = read_only;
+
+    if (read_only) {
+        bs->open_flags &= ~BDRV_O_RDWR;
+    } else {
+        bs->open_flags |= BDRV_O_RDWR;
+    }
+
     return 0;
 }