OSDN Git Service

selftests/bpf: Mark SYN cookie test skipped for UDP sockets
authorJakub Sitnicki <jakub@cloudflare.com>
Wed, 12 Feb 2020 10:32:08 +0000 (10:32 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 12 Feb 2020 16:44:44 +0000 (17:44 +0100)
SYN cookie test with reuseport BPF doesn't make sense for UDP sockets. We
don't run it but the test_progs test runner doesn't know about it. Mark the
test as skipped so the test_progs can report correctly how many tests were
skipped.

Fixes: 7ee0d4e97b88 ("selftests/bpf: Switch reuseport tests for test_progs framework")
Reported-by: Lorenz Bauer <lmb@cloudflare.com>
Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20200212103208.438419-1-jakub@cloudflare.com
tools/testing/selftests/bpf/prog_tests/select_reuseport.c

index b577666..0800036 100644 (file)
@@ -506,8 +506,10 @@ static void test_syncookie(int type, sa_family_t family)
                .pass_on_failure = 0,
        };
 
-       if (type != SOCK_STREAM)
+       if (type != SOCK_STREAM) {
+               test__skip();
                return;
+       }
 
        /*
         * +1 for TCP-SYN and