PATCH: [1374728 ] Fix filter dialog delete

  Src: FileFilterMgr.cpp

diff --git a/Src/Changes.txt b/Src/Changes.txt
index a548334..0f1d9db 100644 (file)
--- a/Src/Changes.txt
+++ b/Src/Changes.txt
@@ -1,3 +1,7 @@
+2005-12-08 Perry
+ PATCH: [1374728 ] Fix filter dialog delete
+  Src: FileFilterMgr.cpp
+
 2005-12-08 Kimmo
  PATCH: [ 1374782 ] fix for bug 1300957 Crash on save 'unique' file comparison
   Submitted by Oliver Mellet, some additional comment improvements by me.

diff --git a/Src/FileFilterMgr.cpp b/Src/FileFilterMgr.cpp
index b58e1c5..0f4c952 100644 (file)
--- a/Src/FileFilterMgr.cpp
+++ b/Src/FileFilterMgr.cpp
@@ -134,9 +134,8 @@ void FileFilterMgr::LoadFromDirectory(LPCTSTR szPattern, LPCTSTR szExt)
  */
 void FileFilterMgr::RemoveFilter(LPCTSTR szFilterFile)
 {
-       const int items = m_filters.GetSize();
-
-       for (int i = 0; i < items; i++)
+       // Note that m_filters.GetSize can change during loop
+       for (int i = 0; i < m_filters.GetSize(); i++)
        {
                FileFilter * pFilter = m_filters.GetAt(i);
                if (pFilter->fullpath.CompareNoCase(szFilterFile) == 0)