OSDN Git Service

net/mlx5: E-switch, Removed unused hwid
authorParav Pandit <parav@mellanox.com>
Fri, 26 Jul 2019 13:26:52 +0000 (08:26 -0500)
committerSaeed Mahameed <saeedm@mellanox.com>
Fri, 9 Aug 2019 21:54:10 +0000 (14:54 -0700)
Currently mlx5_eswitch_rep stores same hw ID for all representors.
However it is never used from this structure.
It is always used from mlx5_vport.

Hence, remove unused field.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Vu Pham <vuhuong@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
include/linux/mlx5/eswitch.h

index 8fe5ddd..42cc500 100644 (file)
@@ -1393,10 +1393,9 @@ void esw_offloads_cleanup_reps(struct mlx5_eswitch *esw)
 int esw_offloads_init_reps(struct mlx5_eswitch *esw)
 {
        int total_vports = esw->total_vports;
-       struct mlx5_core_dev *dev = esw->dev;
        struct mlx5_eswitch_rep *rep;
-       u8 hw_id[ETH_ALEN], rep_type;
        int vport_index;
+       u8 rep_type;
 
        esw->offloads.vport_reps = kcalloc(total_vports,
                                           sizeof(struct mlx5_eswitch_rep),
@@ -1404,12 +1403,9 @@ int esw_offloads_init_reps(struct mlx5_eswitch *esw)
        if (!esw->offloads.vport_reps)
                return -ENOMEM;
 
-       mlx5_query_mac_address(dev, hw_id);
-
        mlx5_esw_for_all_reps(esw, vport_index, rep) {
                rep->vport = mlx5_eswitch_index_to_vport_num(esw, vport_index);
                rep->vport_index = vport_index;
-               ether_addr_copy(rep->hw_id, hw_id);
 
                for (rep_type = 0; rep_type < NUM_REP_TYPES; rep_type++)
                        atomic_set(&rep->rep_data[rep_type].state,
index 46b5ba0..38a70d1 100644 (file)
@@ -44,7 +44,6 @@ struct mlx5_eswitch_rep_data {
 struct mlx5_eswitch_rep {
        struct mlx5_eswitch_rep_data rep_data[NUM_REP_TYPES];
        u16                    vport;
-       u8                     hw_id[ETH_ALEN];
        u16                    vlan;
        /* Only IB rep is using vport_index */
        u16                    vport_index;