OSDN Git Service

coresight: tmc-etr: Disallow perf mode
authorSuzuki K Poulose <suzuki.poulose@arm.com>
Wed, 11 Jul 2018 19:40:17 +0000 (13:40 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 15 Jul 2018 11:52:56 +0000 (13:52 +0200)
We don't support ETR in perf mode yet. So, don't
even try to enable the hardware, even by mistake.

Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/coresight/coresight-tmc-etr.c

index 1de05c9..18c9a18 100644 (file)
@@ -211,32 +211,8 @@ out:
 
 static int tmc_enable_etr_sink_perf(struct coresight_device *csdev)
 {
-       int ret = 0;
-       unsigned long flags;
-       struct tmc_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent);
-
-       spin_lock_irqsave(&drvdata->spinlock, flags);
-       if (drvdata->reading) {
-               ret = -EINVAL;
-               goto out;
-       }
-
-       /*
-        * In Perf mode there can be only one writer per sink.  There
-        * is also no need to continue if the ETR is already operated
-        * from sysFS.
-        */
-       if (drvdata->mode != CS_MODE_DISABLED) {
-               ret = -EINVAL;
-               goto out;
-       }
-
-       drvdata->mode = CS_MODE_PERF;
-       tmc_etr_enable_hw(drvdata);
-out:
-       spin_unlock_irqrestore(&drvdata->spinlock, flags);
-
-       return ret;
+       /* We don't support perf mode yet ! */
+       return -EINVAL;
 }
 
 static int tmc_enable_etr_sink(struct coresight_device *csdev, u32 mode)