OSDN Git Service

crypto: inside-secure - fix missing unlock on error in safexcel_ahash_send_req()
authorweiyongjun \(A\) <weiyongjun1@huawei.com>
Tue, 13 Mar 2018 14:54:03 +0000 (14:54 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 23 Mar 2018 15:39:58 +0000 (23:39 +0800)
Add the missing unlock before return from function
safexcel_ahash_send_req() in the error handling case.

Fixes: cff9a17545a3 ("crypto: inside-secure - move cache result dma mapping to request")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/inside-secure/safexcel_hash.c

index 77268c9..6e9eb9b 100644 (file)
@@ -236,8 +236,10 @@ static int safexcel_ahash_send_req(struct crypto_async_request *async, int ring,
        if (cache_len) {
                req->cache_dma = dma_map_single(priv->dev, req->cache,
                                                cache_len, DMA_TO_DEVICE);
-               if (dma_mapping_error(priv->dev, req->cache_dma))
+               if (dma_mapping_error(priv->dev, req->cache_dma)) {
+                       spin_unlock_bh(&priv->ring[ring].egress_lock);
                        return -EINVAL;
+               }
 
                req->cache_sz = cache_len;
                first_cdesc = safexcel_add_cdesc(priv, ring, 1,