OSDN Git Service

EDAC/amd64: Remove redundant assignment to variable ret in hw_info_get()
authorColin Ian King <colin.king@canonical.com>
Wed, 29 Apr 2020 15:48:47 +0000 (16:48 +0100)
committerBorislav Petkov <bp@suse.de>
Fri, 29 May 2020 13:15:02 +0000 (15:15 +0200)
The variable ret is being assigned with a value that is never read
and it is being updated later with a new value. The initialization is
redundant so remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200429154847.287001-1-colin.king@canonical.com
drivers/edac/amd64_edac.c

index f91f3bc..9cf7cc1 100644 (file)
@@ -3403,7 +3403,7 @@ static const struct attribute_group *amd64_edac_attr_groups[] = {
 static int hw_info_get(struct amd64_pvt *pvt)
 {
        u16 pci_id1, pci_id2;
-       int ret = -EINVAL;
+       int ret;
 
        if (pvt->fam >= 0x17) {
                pvt->umc = kcalloc(fam_type->max_mcs, sizeof(struct amd64_umc), GFP_KERNEL);