OSDN Git Service

crypto: sun8i-ss - remove redundant memzero_explicit()
authorDenis Efremov <efremov@linux.com>
Thu, 27 Aug 2020 12:16:11 +0000 (15:16 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 4 Sep 2020 07:57:17 +0000 (17:57 +1000)
Remove redundant memzero_explicit() in sun8i_ss_cipher() before calling
kfree_sensitive(). kfree_sensitive() will zero the memory with
memzero_explicit().

Fixes: 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()")
Signed-off-by: Denis Efremov <efremov@linux.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c

index deb8b39..ed2a69f 100644 (file)
@@ -248,7 +248,6 @@ theend_iv:
                        offset = areq->cryptlen - ivsize;
                        if (rctx->op_dir & SS_DECRYPTION) {
                                memcpy(areq->iv, backup_iv, ivsize);
-                               memzero_explicit(backup_iv, ivsize);
                                kfree_sensitive(backup_iv);
                        } else {
                                scatterwalk_map_and_copy(areq->iv, areq->dst, offset,