OSDN Git Service

tcp: remove retransmit_skb_hint clearing from failure
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>
Sun, 21 Sep 2008 04:24:49 +0000 (21:24 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 21 Sep 2008 04:24:49 +0000 (21:24 -0700)
This doesn't much sense here afaict, probably never has. Since
fragmenting and collapsing deal the hints by themselves, there
should be very little reason for the rexmit loop to do that.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c

index b5b4ddc..f900fae 100644 (file)
@@ -2096,10 +2096,8 @@ begin_fwd:
                if (sacked & (TCPCB_SACKED_ACKED|TCPCB_SACKED_RETRANS))
                        continue;
 
-               if (tcp_retransmit_skb(sk, skb)) {
-                       tp->retransmit_skb_hint = NULL;
+               if (tcp_retransmit_skb(sk, skb))
                        return;
-               }
                NET_INC_STATS_BH(sock_net(sk), mib_idx);
 
                if (skb == tcp_write_queue_head(sk))