Remove Reactor argument tests for small integers

Booleans and integer types smaller than 32-bit are not readily
supported as arguments by Subzero.

Was broken by https://swiftshader-review.googlesource.com/27251

Change-Id: I0803037100b107ca9f7b627c2effd0493b8ab1a8
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27390
Tested-by: Nicolas Capens <nicolascapens@google.com>
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

diff --git a/src/Reactor/ReactorUnitTests.cpp b/src/Reactor/ReactorUnitTests.cpp
index a50fae8..e44533e 100644 (file)
--- a/src/Reactor/ReactorUnitTests.cpp
+++ b/src/Reactor/ReactorUnitTests.cpp
@@ -1118,7 +1118,8 @@ TEST(ReactorUnitTests, PreserveXMMRegisters)
 }
 
 template <typename T>
-class CToReactorCastTest : public ::testing::Test {
+class CToReactorCastTest : public ::testing::Test
+{
 public:
        using CType = typename std::tuple_element<0, T>::type;
        using ReactorType = typename std::tuple_element<1, T>::type;
@@ -1126,11 +1127,11 @@ public:
 
 using CToReactorCastTestTypes = ::testing::Types
        < // Subset of types that can be used as arguments.
-               std::pair<bool,         Bool>,
-               std::pair<uint8_t,      Byte>,
-               std::pair<int8_t,       SByte>,
-               std::pair<int16_t,      Short>,
-               std::pair<uint16_t,     UShort>,
+       //      std::pair<bool,         Bool>,    FIXME(capn): Not supported as argument type by Subzero.
+       //      std::pair<uint8_t,      Byte>,    FIXME(capn): Not supported as argument type by Subzero.
+       //      std::pair<int8_t,       SByte>,   FIXME(capn): Not supported as argument type by Subzero.
+       //      std::pair<int16_t,      Short>,   FIXME(capn): Not supported as argument type by Subzero.
+       //      std::pair<uint16_t,     UShort>,  FIXME(capn): Not supported as argument type by Subzero.
                std::pair<int,          Int>,
                std::pair<unsigned int, UInt>,
                std::pair<float,        Float>
@@ -1138,7 +1139,8 @@ using CToReactorCastTestTypes = ::testing::Types
 
 TYPED_TEST_CASE(CToReactorCastTest, CToReactorCastTestTypes);
 
-TYPED_TEST(CToReactorCastTest, Casts) {
+TYPED_TEST(CToReactorCastTest, Casts)
+{
        using CType = typename TestFixture::CType;
        using ReactorType = typename TestFixture::ReactorType;
 
@@ -1168,7 +1170,8 @@ TYPED_TEST(CToReactorCastTest, Casts) {
 }
 
 template <typename T>
-class GEPTest : public ::testing::Test {
+class GEPTest : public ::testing::Test
+{
 public:
        using CType = typename std::tuple_element<0, T>::type;
        using ReactorType = typename std::tuple_element<1, T>::type;
@@ -1208,7 +1211,8 @@ using GEPTestTypes = ::testing::Types
 
 TYPED_TEST_CASE(GEPTest, GEPTestTypes);
 
-TYPED_TEST(GEPTest, PtrOffsets) {
+TYPED_TEST(GEPTest, PtrOffsets)
+{
        using CType = typename TestFixture::CType;
        using ReactorType = typename TestFixture::ReactorType;
 

diff --git a/src/Reactor/ReactorUnitTests.vcxproj.user b/src/Reactor/ReactorUnitTests.vcxproj.user
new file mode 100644 (file)
index 0000000..241b1fa
--- /dev/null
+++ b/src/Reactor/ReactorUnitTests.vcxproj.user
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>\r
+<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">\r
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">\r
+    <LocalDebuggerCommandArguments>--gtest_break_on_failure --gtest_filter=*</LocalDebuggerCommandArguments>\r
+    <DebuggerFlavor>WindowsLocalDebugger</DebuggerFlavor>\r
+  </PropertyGroup>\r
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">\r
+    <LocalDebuggerCommandArguments>--gtest_break_on_failure --gtest_filter=*</LocalDebuggerCommandArguments>\r
+    <DebuggerFlavor>WindowsLocalDebugger</DebuggerFlavor>\r
+  </PropertyGroup>\r
+</Project>
\ No newline at end of file