crypto: qat - no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Conor McLoughlin <conor.mcloughlin@intel.com>
Cc: Waiman Long <longman@redhat.com>
Cc: qat-linux@intel.com
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/qat/qat_c3xxx/adf_drv.c b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
index 763c216..d937cc7 100644 (file)
--- a/drivers/crypto/qat/qat_c3xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
index 613c7d5..1dc5ac8 100644 (file)
--- a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_c62x/adf_drv.c b/drivers/crypto/qat/qat_c62x/adf_drv.c
index 9cb8329..2bc06c8 100644 (file)
--- a/drivers/crypto/qat/qat_c62x/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62x/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_c62xvf/adf_drv.c b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
index 278452b..a68358b 100644 (file)
--- a/drivers/crypto/qat/qat_c62xvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_common/adf_cfg.c b/drivers/crypto/qat/qat_common/adf_cfg.c
index d087979..5c7fdb0 100644 (file)
--- a/drivers/crypto/qat/qat_common/adf_cfg.c
+++ b/drivers/crypto/qat/qat_common/adf_cfg.c
@@ -141,13 +141,6 @@ int adf_cfg_dev_add(struct adf_accel_dev *accel_dev)
                                                  accel_dev->debugfs_dir,
                                                  dev_cfg_data,
                                                  &qat_dev_cfg_fops);
-       if (!dev_cfg_data->debug) {
-               dev_err(&GET_DEV(accel_dev),
-                       "Failed to create qat cfg debugfs entry.\n");
-               kfree(dev_cfg_data);
-               accel_dev->cfg = NULL;
-               return -EFAULT;
-       }
        return 0;
 }
 EXPORT_SYMBOL_GPL(adf_cfg_dev_add);

diff --git a/drivers/crypto/qat/qat_common/adf_transport.c b/drivers/crypto/qat/qat_common/adf_transport.c
index 57d2622..ac658ce 100644 (file)
--- a/drivers/crypto/qat/qat_common/adf_transport.c
+++ b/drivers/crypto/qat/qat_common/adf_transport.c
@@ -486,12 +486,6 @@ int adf_init_etr_data(struct adf_accel_dev *accel_dev)
        /* accel_dev->debugfs_dir should always be non-NULL here */
        etr_data->debug = debugfs_create_dir("transport",
                                             accel_dev->debugfs_dir);
-       if (!etr_data->debug) {
-               dev_err(&GET_DEV(accel_dev),
-                       "Unable to create transport debugfs entry\n");
-               ret = -ENOENT;
-               goto err_bank_debug;
-       }
 
        for (i = 0; i < num_banks; i++) {
                ret = adf_init_bank(accel_dev, &etr_data->banks[i], i,

diff --git a/drivers/crypto/qat/qat_common/adf_transport_debug.c b/drivers/crypto/qat/qat_common/adf_transport_debug.c
index 52340b9..e794e9d 100644 (file)
--- a/drivers/crypto/qat/qat_common/adf_transport_debug.c
+++ b/drivers/crypto/qat/qat_common/adf_transport_debug.c
@@ -163,11 +163,6 @@ int adf_ring_debugfs_add(struct adf_etr_ring_data *ring, const char *name)
        ring_debug->debug = debugfs_create_file(entry_name, S_IRUSR,
                                                ring->bank->bank_debug_dir,
                                                ring, &adf_ring_debug_fops);
-       if (!ring_debug->debug) {
-               pr_err("QAT: Failed to create ring debug entry.\n");
-               kfree(ring_debug);
-               return -EFAULT;
-       }
        ring->ring_debug = ring_debug;
        return 0;
 }
@@ -271,19 +266,9 @@ int adf_bank_debugfs_add(struct adf_etr_bank_data *bank)
 
        snprintf(name, sizeof(name), "bank_%02d", bank->bank_number);
        bank->bank_debug_dir = debugfs_create_dir(name, parent);
-       if (!bank->bank_debug_dir) {
-               pr_err("QAT: Failed to create bank debug dir.\n");
-               return -EFAULT;
-       }
-
        bank->bank_debug_cfg = debugfs_create_file("config", S_IRUSR,
                                                   bank->bank_debug_dir, bank,
                                                   &adf_bank_debug_fops);
-       if (!bank->bank_debug_cfg) {
-               pr_err("QAT: Failed to create bank debug entry.\n");
-               debugfs_remove(bank->bank_debug_dir);
-               return -EFAULT;
-       }
        return 0;
 }
 

diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
index 3a9708e..b11bf8c 100644 (file)
--- a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);

diff --git a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
index 3da0f95..1b762ee 100644 (file)
--- a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                 PCI_FUNC(pdev->devfn));
 
        accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
-       if (!accel_dev->debugfs_dir) {
-               dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
-               ret = -EINVAL;
-               goto out_err;
-       }
 
        /* Create device configuration table */
        ret = adf_cfg_dev_add(accel_dev);