OSDN Git Service

drm/amdgpu/gfx8: fix bugon.cocci warnings
authorJulia Lawall <julia.lawall@lip6.fr>
Tue, 10 Jan 2017 05:52:59 +0000 (06:52 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 27 Jan 2017 16:13:30 +0000 (11:13 -0500)
 Use BUG_ON instead of a if condition followed by BUG.

Generated by: scripts/coccinelle/misc/bugon.cocci

Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewd-by: Xiangliang.Yu <Xiangliang.Yu@amd.com>
CC: Xiangliang Yu <Xiangliang.Yu@amd.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c

index aa053f6..c8c45ba 100644 (file)
@@ -6671,8 +6671,7 @@ static void gfx_v8_0_ring_emit_fence_kiq(struct amdgpu_ring *ring, u64 addr,
                                         u64 seq, unsigned int flags)
 {
        /* we only allocate 32bit for each seq wb address */
-       if (flags & AMDGPU_FENCE_FLAG_64BIT)
-               BUG();
+       BUG_ON(flags & AMDGPU_FENCE_FLAG_64BIT);
 
        /* write fence seq to the "addr" */
        amdgpu_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));