OSDN Git Service

Revert "drm/i915/tgl/psr: Fix glitches when doing frontbuffer modifications"
authorJosé Roberto de Souza <jose.souza@intel.com>
Thu, 8 Apr 2021 20:49:17 +0000 (13:49 -0700)
committerJosé Roberto de Souza <jose.souza@intel.com>
Mon, 12 Apr 2021 16:45:36 +0000 (09:45 -0700)
This reverts commit 71c1a4998320962f7b8362b2c5ee36610d49e8fb.

The proper fix is Wa_14013723622, so now we can revert this WA and
get back some power savings.

Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Tested-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210408204917.254272-2-jose.souza@intel.com
drivers/gpu/drm/i915/display/intel_psr.c

index 2627d0b..bf8e4ed 100644 (file)
@@ -1167,21 +1167,7 @@ static void psr_force_hw_tracking_exit(struct intel_dp *intel_dp)
 {
        struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
 
-       if (IS_TIGERLAKE(dev_priv))
-               /*
-                * Writes to CURSURFLIVE in TGL are causing IOMMU errors and
-                * visual glitches that are often reproduced when executing
-                * CPU intensive workloads while a eDP 4K panel is attached.
-                *
-                * Manually exiting PSR causes the frontbuffer to be updated
-                * without glitches and the IOMMU errors are also gone but
-                * this comes at the cost of less time with PSR active.
-                *
-                * So using this workaround until this issue is root caused
-                * and a better fix is found.
-                */
-               intel_psr_exit(intel_dp);
-       else if (DISPLAY_VER(dev_priv) >= 9)
+       if (DISPLAY_VER(dev_priv) >= 9)
                /*
                 * Display WA #0884: skl+
                 * This documented WA for bxt can be safely applied