OSDN Git Service

btrfs: fix error pointer check in __btrfs_map_block()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 9 Aug 2019 14:07:39 +0000 (17:07 +0300)
committerDavid Sterba <dsterba@suse.com>
Mon, 9 Sep 2019 12:59:12 +0000 (14:59 +0200)
The btrfs_get_chunk_map() never returns NULL, it returns error pointers.

Fixes: 89b798ad1b42 ("btrfs: Use btrfs_get_io_geometry appropriately")
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/volumes.c

index 4852692..e2de7c7 100644 (file)
@@ -6023,7 +6023,7 @@ static int __btrfs_map_block(struct btrfs_fs_info *fs_info,
                return ret;
 
        em = btrfs_get_chunk_map(fs_info, logical, *length);
-       ASSERT(em);
+       ASSERT(!IS_ERR(em));
        map = em->map_lookup;
 
        *length = geom.len;