OSDN Git Service

i40e: remove unnecessary cleaned_count updates
authorCristian Dumitrescu <cristian.dumitrescu@intel.com>
Thu, 14 Jan 2021 14:33:16 +0000 (14:33 +0000)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 9 Feb 2021 01:19:03 +0000 (17:19 -0800)
For performance reasons, remove the redundant updates of the cleaned_count
variable, as its value can be computed based on the ring next-to-clean
variable, which is consistently updated.

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Tested-by: Kiran Bhandare <kiranx.bhandare@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/i40e/i40e_xsk.c

index 87d4340..99082ab 100644 (file)
@@ -300,7 +300,6 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
                        bi = i40e_rx_bi(rx_ring, next_to_clean);
                        xsk_buff_free(*bi);
                        *bi = NULL;
-                       cleaned_count++;
                        next_to_clean = (next_to_clean + 1) & count_mask;
                        continue;
                }
@@ -325,7 +324,6 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
                        total_rx_bytes += size;
                        total_rx_packets++;
 
-                       cleaned_count++;
                        next_to_clean = (next_to_clean + 1) & count_mask;
                        continue;
                }
@@ -344,7 +342,6 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
                }
 
                *bi = NULL;
-               cleaned_count++;
                next_to_clean = (next_to_clean + 1) & count_mask;
 
                if (eth_skb_pad(skb))
@@ -358,6 +355,7 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
        }
 
        rx_ring->next_to_clean = next_to_clean;
+       cleaned_count = (next_to_clean - rx_ring->next_to_use - 1) & count_mask;
 
        if (cleaned_count >= I40E_RX_BUFFER_WRITE)
                failure = !i40e_alloc_rx_buffers_zc(rx_ring, cleaned_count);