OSDN Git Service

media: mtk-vcodec: Remove redundant 'flush_workqueue()' calls
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 14 Oct 2021 18:12:35 +0000 (19:12 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 15 Nov 2021 08:12:07 +0000 (08:12 +0000)
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
-  flush_workqueue(E);
destroy_workqueue(E);

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c

index e6e6a82..68abb14 100644 (file)
@@ -390,7 +390,6 @@ static int mtk_vcodec_dec_remove(struct platform_device *pdev)
 {
        struct mtk_vcodec_dev *dev = platform_get_drvdata(pdev);
 
-       flush_workqueue(dev->decode_workqueue);
        destroy_workqueue(dev->decode_workqueue);
 
        if (media_devnode_is_registered(dev->mdev_dec.devnode)) {
index eed6739..b576f44 100644 (file)
@@ -461,7 +461,6 @@ static int mtk_vcodec_enc_remove(struct platform_device *pdev)
        struct mtk_vcodec_dev *dev = platform_get_drvdata(pdev);
 
        mtk_v4l2_debug_enter();
-       flush_workqueue(dev->encode_workqueue);
        destroy_workqueue(dev->encode_workqueue);
        if (dev->m2m_dev_enc)
                v4l2_m2m_release(dev->m2m_dev_enc);