OSDN Git Service
(root)
/
qmiga
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
549fb88
)
qemu-img: Fix options leakage in img_rebase()
author
Max Reitz
<mreitz@redhat.com>
Tue, 28 May 2019 19:53:38 +0000
(21:53 +0200)
committer
Max Reitz
<mreitz@redhat.com>
Fri, 14 Jun 2019 12:16:57 +0000
(14:16 +0200)
img_rebase() can leak a QDict in two occasions. Fix it.
Coverity: CID
1401416
Fixes:
d16699b64671466b42079c45b89127aeea1ca565
Fixes:
330c72957196e0ae382abcaa97ebf4eb9bc8574f
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id:
20190528195338
.12376-1-mreitz@redhat.com
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
qemu-img.c
patch
|
blob
|
history
diff --git
a/qemu-img.c
b/qemu-img.c
index
fd62e3a
..
da14aea
100644
(file)
--- a/
qemu-img.c
+++ b/
qemu-img.c
@@
-3350,6
+3350,7
@@
static int img_rebase(int argc, char **argv)
out_baseimg,
&local_err);
if (local_err) {
+ qobject_unref(options);
error_reportf_err(local_err,
"Could not resolve backing filename: ");
ret = -1;
@@
-3362,7
+3363,9
@@
static int img_rebase(int argc, char **argv)
*/
prefix_chain_bs = bdrv_find_backing_image(bs, out_real_path);
if (prefix_chain_bs) {
+ qobject_unref(options);
g_free(out_real_path);
+
blk_new_backing = blk_new(qemu_get_aio_context(),
BLK_PERM_CONSISTENT_READ,
BLK_PERM_ALL);