soc: qcom: rpmh-rsc: Fold WARN_ON() into if condition

Move the WARN_ON() into the if condition so the compiler can see that
the branch is unlikely() and possibly optimize it better.

Cc: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20200521060425.24285-4-swboyd@chromium.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index 49c2456..e749a2b 100644 (file)
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -394,10 +394,8 @@ static irqreturn_t tcs_tx_done(int irq, void *p)
 
        for_each_set_bit(i, &irq_status, BITS_PER_TYPE(u32)) {
                req = get_req_from_tcs(drv, i);
-               if (!req) {
-                       WARN_ON(1);
+               if (WARN_ON(!req))
                        goto skip;
-               }
 
                err = 0;
                for (j = 0; j < req->num_cmds; j++) {