OSDN Git Service

i40e: Fix the conditional for i40e_vc_validate_vqs_bitmaps
authorBrett Creeley <brett.creeley@intel.com>
Mon, 10 Feb 2020 18:59:18 +0000 (10:59 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Feb 2020 01:03:52 +0000 (17:03 -0800)
Commit d9d6a9aed3f6 ("i40e: Fix virtchnl_queue_select bitmap
validation") introduced a necessary change for verifying how queue
bitmaps from the iavf driver get validated. Unfortunately, the
conditional was reversed. Fix this.

Fixes: d9d6a9aed3f6 ("i40e: Fix virtchnl_queue_select bitmap validation")
Signed-off-by: Brett Creeley <brett.creeley@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

index 69523ac..56b9e44 100644 (file)
@@ -2362,7 +2362,7 @@ static int i40e_vc_enable_queues_msg(struct i40e_vf *vf, u8 *msg)
                goto error_param;
        }
 
-       if (i40e_vc_validate_vqs_bitmaps(vqs)) {
+       if (!i40e_vc_validate_vqs_bitmaps(vqs)) {
                aq_ret = I40E_ERR_PARAM;
                goto error_param;
        }
@@ -2424,7 +2424,7 @@ static int i40e_vc_disable_queues_msg(struct i40e_vf *vf, u8 *msg)
                goto error_param;
        }
 
-       if (i40e_vc_validate_vqs_bitmaps(vqs)) {
+       if (!i40e_vc_validate_vqs_bitmaps(vqs)) {
                aq_ret = I40E_ERR_PARAM;
                goto error_param;
        }