OSDN Git Service

i2c: sh_mobile: remove redundant initialization
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 2 Nov 2017 12:47:27 +0000 (13:47 +0100)
committerWolfram Sang <wsa@the-dreams.de>
Mon, 27 Nov 2017 17:52:51 +0000 (18:52 +0100)
Following the documentation, we initialize the HW before each START in
start_ch(). No need to do the same in activate_ch().

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-sh_mobile.c

index c03acdf..0ac1525 100644 (file)
@@ -303,16 +303,6 @@ static void activate_ch(struct sh_mobile_i2c_data *pd)
        /* Wake up device and enable clock */
        pm_runtime_get_sync(pd->dev);
        clk_prepare_enable(pd->clk);
-
-       /* Enable channel and configure rx ack */
-       iic_set_clr(pd, ICCR, ICCR_ICE, 0);
-
-       /* Mask all interrupts */
-       iic_wr(pd, ICIC, 0);
-
-       /* Set the clock */
-       iic_wr(pd, ICCL, pd->iccl & 0xff);
-       iic_wr(pd, ICCH, pd->icch & 0xff);
 }
 
 static void deactivate_ch(struct sh_mobile_i2c_data *pd)