OSDN Git Service

CIFS: remove set but not used variables 'cinode' and 'netfid'
authorYueHaibing <yuehaibing@huawei.com>
Thu, 17 Oct 2019 03:53:51 +0000 (03:53 +0000)
committerSteve French <stfrench@microsoft.com>
Mon, 25 Nov 2019 07:14:14 +0000 (01:14 -0600)
Fixes gcc '-Wunused-but-set-variable' warning:

fs/cifs/file.c: In function 'cifs_flock':
fs/cifs/file.c:1704:8: warning:
 variable 'netfid' set but not used [-Wunused-but-set-variable]

fs/cifs/file.c:1702:24: warning:
 variable 'cinode' set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/file.c

index f3fd5b6..a80ec68 100644 (file)
@@ -1706,9 +1706,7 @@ int cifs_flock(struct file *file, int cmd, struct file_lock *fl)
        bool posix_lck = false;
        struct cifs_sb_info *cifs_sb;
        struct cifs_tcon *tcon;
-       struct cifsInodeInfo *cinode;
        struct cifsFileInfo *cfile;
-       __u16 netfid;
        __u32 type;
 
        rc = -EACCES;
@@ -1723,8 +1721,6 @@ int cifs_flock(struct file *file, int cmd, struct file_lock *fl)
        cifs_read_flock(fl, &type, &lock, &unlock, &wait_flag,
                        tcon->ses->server);
        cifs_sb = CIFS_FILE_SB(file);
-       netfid = cfile->fid.netfid;
-       cinode = CIFS_I(file_inode(file));
 
        if (cap_unix(tcon->ses) &&
            (CIFS_UNIX_FCNTL_CAP & le64_to_cpu(tcon->fsUnixInfo.Capability)) &&