OSDN Git Service

[media] sh_veu.c: Convert to devm_ioremap_resource()
authorSachin Kamat <sachin.kamat@linaro.org>
Mon, 4 Mar 2013 08:15:18 +0000 (05:15 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Mar 2013 17:35:14 +0000 (14:35 -0300)
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/platform/sh_veu.c

index cb54c69..362d88e 100644 (file)
@@ -10,6 +10,7 @@
  * published by the Free Software Foundation
  */
 
+#include <linux/err.h>
 #include <linux/fs.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
@@ -1164,9 +1165,9 @@ static int sh_veu_probe(struct platform_device *pdev)
 
        veu->is_2h = resource_size(reg_res) == 0x22c;
 
-       veu->base = devm_request_and_ioremap(&pdev->dev, reg_res);
-       if (!veu->base)
-               return -ENOMEM;
+       veu->base = devm_ioremap_resource(&pdev->dev, reg_res);
+       if (IS_ERR(veu->base))
+               return PTR_ERR(veu->base);
 
        ret = devm_request_threaded_irq(&pdev->dev, irq, sh_veu_isr, sh_veu_bh,
                                        0, "veu", veu);