OSDN Git Service

MIPS: Disallow outsized PTRACE_SETREGSET NT_PRFPREG regset accesses
authorMaciej W. Rozycki <macro@mips.com>
Mon, 11 Dec 2017 22:56:54 +0000 (22:56 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jan 2018 08:35:25 +0000 (09:35 +0100)
commit c8c5a3a24d395b14447a9a89d61586a913840a3b upstream.

Complement commit c23b3d1a5311 ("MIPS: ptrace: Change GP regset to use
correct core dump register layout") and also reject outsized
PTRACE_SETREGSET requests to the NT_PRFPREG regset, like with the
NT_PRSTATUS regset.

Signed-off-by: Maciej W. Rozycki <macro@mips.com>
Fixes: c23b3d1a5311 ("MIPS: ptrace: Change GP regset to use correct core dump register layout")
Cc: James Hogan <james.hogan@mips.com>
Cc: Paul Burton <Paul.Burton@mips.com>
Cc: Alex Smith <alex@alex-smith.me.uk>
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/17930/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/mips/kernel/ptrace.c

index aa92e13..c3d2d2c 100644 (file)
@@ -570,6 +570,9 @@ static int fpr_set(struct task_struct *target,
 
        BUG_ON(count % sizeof(elf_fpreg_t));
 
+       if (pos + count > sizeof(elf_fpregset_t))
+               return -EIO;
+
        init_fp_ctx(target);
 
        if (sizeof(target->thread.fpu.fpr[0]) == sizeof(elf_fpreg_t))