OSDN Git Service

[media] fix a warning on avr32 arch
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 30 Oct 2014 10:16:57 +0000 (07:16 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 3 Nov 2014 17:53:15 +0000 (15:53 -0200)
X-Patchwork-Delegate: m.chehab@samsung.com
on avr32 arch, those warnings happen:
drivers/media/firewire/firedtv-fw.c: In function 'node_update':
drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always true due to limited range of data type

In this particular case, the signal is desired, as the isochannel
var can be initalized with -1 inside the driver.

So, change the type to s8, to avoid issues on archs where char
is unsigned.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Reviewed-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/firewire/firedtv.h

index c2ba085..346a85b 100644 (file)
@@ -96,7 +96,7 @@ struct firedtv {
 
        enum model_type         type;
        char                    subunit;
-       char                    isochannel;
+       s8                      isochannel;
        struct fdtv_ir_context  *ir_context;
 
        fe_sec_voltage_t        voltage;