OSDN Git Service

net: phy: mscc: use phy_trigger_machine() to notify link change
authorIoana Ciornei <ioana.ciornei@nxp.com>
Sun, 1 Nov 2020 12:51:01 +0000 (14:51 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 6 Nov 2020 00:31:59 +0000 (16:31 -0800)
According to the comment describing the phy_mac_interrupt() function, it
it intended to be used by MAC drivers which have noticed a link change
thus its use in the mscc PHY driver is improper and, most probably, was
added just because phy_trigger_machine() was not exported.
Now that we have acces to trigger the link state machine, use directly
the phy_trigger_machine() function to notify a link change detected by
the PHY driver.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/mscc/mscc_main.c

index 6bc7406..b705121 100644 (file)
@@ -1498,7 +1498,7 @@ static irqreturn_t vsc8584_handle_interrupt(struct phy_device *phydev)
                vsc8584_handle_macsec_interrupt(phydev);
 
        if (irq_status & MII_VSC85XX_INT_MASK_LINK_CHG)
-               phy_mac_interrupt(phydev);
+               phy_trigger_machine(phydev);
 
        return IRQ_HANDLED;
 }