drm: mali-dp: Uninitialized variable in malidp_se_check_scaling()

We use "mc" without initializing it if scaling is not necessary.

Fixes: 28ce675b7474 ("drm: mali-dp: Add plane upscaling support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mihail Atanassov <Mihail.Atanassov@arm.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>

diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
index a307fc2..6f813c4 100644 (file)
--- a/drivers/gpu/drm/arm/malidp_planes.c
+++ b/drivers/gpu/drm/arm/malidp_planes.c
@@ -147,6 +147,8 @@ static int malidp_se_check_scaling(struct malidp_plane *mp,
        if (!crtc_state)
                return -EINVAL;
 
+       mc = to_malidp_crtc_state(crtc_state);
+
        ret = drm_atomic_helper_check_plane_state(state, crtc_state,
                                                  0, INT_MAX, true, true);
        if (ret)
@@ -163,8 +165,6 @@ static int malidp_se_check_scaling(struct malidp_plane *mp,
        if (mp->layer->id & (DE_SMART | DE_GRAPHICS2))
                return -EINVAL;
 
-       mc = to_malidp_crtc_state(crtc_state);
-
        mc->scaled_planes_mask |= mp->layer->id;
        /* Defer scaling requirements calculation to the crtc check. */
        return 0;