clk: renesas: Zero init clk_init_data

As clk_core_populate_parent_map() checks clk_init_data.num_parents
first, and checks clk_init_data.parent_names[] before
clk_init_data.parent_data[] and clk_init_data.parent_hws[], leaving the
latter uninitialized doesn't do harm for now.  However, it is better to
play it safe, and initialize all clk_init_data structures to zeroes, to
avoid any current and future members containing uninitialized data.

Remove a few explicit zero initializers, which are now superfluous.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20210326105434.1574796-1-geert+renesas@glider.be

diff --git a/drivers/clk/renesas/clk-div6.c b/drivers/clk/renesas/clk-div6.c
index 5ca183e..8fb68e7 100644 (file)
--- a/drivers/clk/renesas/clk-div6.c
+++ b/drivers/clk/renesas/clk-div6.c
@@ -216,7 +216,7 @@ struct clk * __init cpg_div6_register(const char *name,
                                      struct raw_notifier_head *notifiers)
 {
        unsigned int valid_parents;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        struct div6_clock *clock;
        struct clk *clk;
        unsigned int i;
@@ -267,7 +267,6 @@ struct clk * __init cpg_div6_register(const char *name,
        /* Register the clock. */
        init.name = name;
        init.ops = &cpg_div6_clock_ops;
-       init.flags = 0;
        init.parent_names = parent_names;
        init.num_parents = valid_parents;
 

diff --git a/drivers/clk/renesas/clk-mstp.c b/drivers/clk/renesas/clk-mstp.c
index 003e9ce..90804ac 100644 (file)
--- a/drivers/clk/renesas/clk-mstp.c
+++ b/drivers/clk/renesas/clk-mstp.c
@@ -150,7 +150,7 @@ static struct clk * __init cpg_mstp_clock_register(const char *name,
        const char *parent_name, unsigned int index,
        struct mstp_clock_group *group)
 {
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        struct mstp_clock *clock;
        struct clk *clk;
 

diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c
index 1fe166e..71b1144 100644 (file)
--- a/drivers/clk/renesas/r9a06g032-clocks.c
+++ b/drivers/clk/renesas/r9a06g032-clocks.c
@@ -504,7 +504,7 @@ r9a06g032_register_gate(struct r9a06g032_priv *clocks,
 {
        struct clk *clk;
        struct r9a06g032_clk_gate *g;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
 
        g = kzalloc(sizeof(*g), GFP_KERNEL);
        if (!g)
@@ -674,7 +674,7 @@ r9a06g032_register_div(struct r9a06g032_priv *clocks,
 {
        struct r9a06g032_clk_div *div;
        struct clk *clk;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        unsigned int i;
 
        div = kzalloc(sizeof(*div), GFP_KERNEL);
@@ -758,7 +758,7 @@ r9a06g032_register_bitsel(struct r9a06g032_priv *clocks,
 {
        struct clk *clk;
        struct r9a06g032_clk_bitsel *g;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        const char *names[2];
 
        /* allocate the gate */
@@ -849,7 +849,7 @@ r9a06g032_register_dualgate(struct r9a06g032_priv *clocks,
 {
        struct r9a06g032_clk_dualgate *g;
        struct clk *clk;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
 
        /* allocate the gate */
        g = kzalloc(sizeof(*g), GFP_KERNEL);

diff --git a/drivers/clk/renesas/rcar-cpg-lib.c b/drivers/clk/renesas/rcar-cpg-lib.c
index 7e7e5d1..5678768 100644 (file)
--- a/drivers/clk/renesas/rcar-cpg-lib.c
+++ b/drivers/clk/renesas/rcar-cpg-lib.c
@@ -226,7 +226,7 @@ struct clk * __init cpg_sd_clk_register(const char *name,
        void __iomem *base, unsigned int offset, const char *parent_name,
        struct raw_notifier_head *notifiers, bool skip_first)
 {
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        struct sd_clock *clock;
        struct clk *clk;
        u32 val;

diff --git a/drivers/clk/renesas/rcar-gen2-cpg.c b/drivers/clk/renesas/rcar-gen2-cpg.c
index d4fa3dc..edae874 100644 (file)
--- a/drivers/clk/renesas/rcar-gen2-cpg.c
+++ b/drivers/clk/renesas/rcar-gen2-cpg.c
@@ -137,7 +137,7 @@ static struct clk * __init cpg_z_clk_register(const char *name,
                                              const char *parent_name,
                                              void __iomem *base)
 {
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        struct cpg_z_clk *zclk;
        struct clk *clk;
 
@@ -147,7 +147,6 @@ static struct clk * __init cpg_z_clk_register(const char *name,
 
        init.name = name;
        init.ops = &cpg_z_clk_ops;
-       init.flags = 0;
        init.parent_names = &parent_name;
        init.num_parents = 1;
 

diff --git a/drivers/clk/renesas/rcar-gen3-cpg.c b/drivers/clk/renesas/rcar-gen3-cpg.c
index 1782659..caa0f94 100644 (file)
--- a/drivers/clk/renesas/rcar-gen3-cpg.c
+++ b/drivers/clk/renesas/rcar-gen3-cpg.c
@@ -143,7 +143,7 @@ static struct clk * __init cpg_z_clk_register(const char *name,
                                              unsigned int div,
                                              unsigned int offset)
 {
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        struct cpg_z_clk *zclk;
        struct clk *clk;
 

diff --git a/drivers/clk/renesas/rcar-usb2-clock-sel.c b/drivers/clk/renesas/rcar-usb2-clock-sel.c
index 3abafd7..34a85dc 100644 (file)
--- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
+++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
@@ -144,7 +144,7 @@ static int rcar_usb2_clock_sel_probe(struct platform_device *pdev)
        struct device_node *np = dev->of_node;
        struct usb2_clock_sel_priv *priv;
        struct clk *clk;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        int ret;
 
        priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
@@ -188,9 +188,6 @@ static int rcar_usb2_clock_sel_probe(struct platform_device *pdev)
 
        init.name = "rcar_usb2_clock_sel";
        init.ops = &usb2_clock_sel_clock_ops;
-       init.flags = 0;
-       init.parent_names = NULL;
-       init.num_parents = 0;
        priv->hw.init = &init;
 
        clk = clk_register(NULL, &priv->hw);

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index bffbc3d..fc531d3 100644 (file)
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -408,7 +408,7 @@ static void __init cpg_mssr_register_mod_clk(const struct mssr_mod_clk *mod,
        struct mstp_clock *clock = NULL;
        struct device *dev = priv->dev;
        unsigned int id = mod->id;
-       struct clk_init_data init;
+       struct clk_init_data init = {};
        struct clk *parent, *clk;
        const char *parent_name;
        unsigned int i;