OSDN Git Service

ASoC: Intel: avs: Simplify probe-component implementation
authorCezary Rojewski <cezary.rojewski@intel.com>
Mon, 23 Jan 2023 12:21:44 +0000 (13:21 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 23 Jan 2023 13:31:01 +0000 (13:31 +0000)
There is no need for the probe-component to be part of the PCM component
list as it does not make use of ASoC-topology and does not participate
in creating any PCM streams.

To achieve that, remove probe() and remove() functions.

Fixes: ed914a2a45a4 ("ASoC: Intel: avs: Data probing soc-component")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20230123122144.1356890-1-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/probes.c

index 29d63f2..b04f2d1 100644 (file)
@@ -277,31 +277,8 @@ static struct snd_soc_dai_driver probe_cpu_dais[] = {
 },
 };
 
-static int avs_probe_component_probe(struct snd_soc_component *component)
-{
-       struct avs_soc_component *acomp = to_avs_soc_component(component);
-       struct avs_dev *adev = to_avs_dev(component->dev);
-
-       mutex_lock(&adev->comp_list_mutex);
-       list_add_tail(&acomp->node, &adev->comp_list);
-       mutex_unlock(&adev->comp_list_mutex);
-       return 0;
-}
-
-static void avs_probe_component_remove(struct snd_soc_component *component)
-{
-       struct avs_soc_component *acomp = to_avs_soc_component(component);
-       struct avs_dev *adev = to_avs_dev(component->dev);
-
-       mutex_lock(&adev->comp_list_mutex);
-       list_del(&acomp->node);
-       mutex_unlock(&adev->comp_list_mutex);
-}
-
 static const struct snd_soc_component_driver avs_probe_component_driver = {
        .name                   = "avs-probe-compr",
-       .probe                  = avs_probe_component_probe,
-       .remove                 = avs_probe_component_remove,
        .compress_ops           = &avs_probe_compress_ops,
        .module_get_upon_open   = 1, /* increment refcount when a stream is opened */
 };