OSDN Git Service

net: ethernet: dwmac: remove redundant null check before clk_disable_unprepare()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Mon, 7 Sep 2020 12:46:54 +0000 (20:46 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 7 Sep 2020 20:34:51 +0000 (13:34 -0700)
Because clk_prepare_enable() and clk_disable_unprepare() already checked
NULL clock parameter, so the additional checks are unnecessary, just
remove them.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c

index 3c5df5e..efef547 100644 (file)
@@ -129,8 +129,7 @@ static void imx_dwmac_exit(struct platform_device *pdev, void *priv)
 {
        struct imx_priv_data *dwmac = priv;
 
-       if (dwmac->clk_tx)
-               clk_disable_unprepare(dwmac->clk_tx);
+       clk_disable_unprepare(dwmac->clk_tx);
        clk_disable_unprepare(dwmac->clk_mem);
 }