OSDN Git Service

hsr: use debugfs_remove_recursive() instead of debugfs_remove()
authorTaehee Yoo <ap420073@gmail.com>
Fri, 28 Feb 2020 18:01:20 +0000 (18:01 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Mar 2020 05:37:03 +0000 (21:37 -0800)
If it uses debugfs_remove_recursive() instead of debugfs_remove(),
hsr_priv() doesn't need to have "node_tbl_file" pointer variable.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/hsr/hsr_debugfs.c
net/hsr/hsr_main.h

index d5f709b..9787ef1 100644 (file)
@@ -113,7 +113,6 @@ void hsr_debugfs_init(struct hsr_priv *priv, struct net_device *hsr_dev)
                priv->node_tbl_root = NULL;
                return;
        }
-       priv->node_tbl_file = de;
 }
 
 /* hsr_debugfs_term - Tear down debugfs intrastructure
@@ -125,9 +124,7 @@ void hsr_debugfs_init(struct hsr_priv *priv, struct net_device *hsr_dev)
 void
 hsr_debugfs_term(struct hsr_priv *priv)
 {
-       debugfs_remove(priv->node_tbl_file);
-       priv->node_tbl_file = NULL;
-       debugfs_remove(priv->node_tbl_root);
+       debugfs_remove_recursive(priv->node_tbl_root);
        priv->node_tbl_root = NULL;
 }
 
index 754d84b..7321cf8 100644 (file)
@@ -166,7 +166,6 @@ struct hsr_priv {
        unsigned char           sup_multicast_addr[ETH_ALEN];
 #ifdef CONFIG_DEBUG_FS
        struct dentry *node_tbl_root;
-       struct dentry *node_tbl_file;
 #endif
 };