OSDN Git Service

Staging: iio: adt7316: Fix i2c data reading, set the data field
authorShreeya Patel <shreeya.patel23498@gmail.com>
Fri, 16 Nov 2018 22:49:07 +0000 (04:19 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Dec 2019 09:34:31 +0000 (10:34 +0100)
[ Upstream commit 688cd642ba0c393344c802647848da5f0d925d0e ]

adt7316_i2c_read function nowhere sets the data field.
It is necessary to have an appropriate value for it.
Hence, assign the value stored in 'ret' variable to data field.

This is an ancient bug, and as no one seems to have noticed,
probably no sense in applying it to stable.

Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/iio/addac/adt7316-i2c.c

index 78fe0b5..fa1ef25 100644 (file)
@@ -35,6 +35,8 @@ static int adt7316_i2c_read(void *client, u8 reg, u8 *data)
                return ret;
        }
 
+       *data = ret;
+
        return 0;
 }